Skip to content

Do not show 'pip3_import' as alternative to 'pip_install' in README#398

Merged
thundergolfer merged 1 commit intomasterfrom
jonathon--remove-pip3_import_refs-from-README
Jan 5, 2021
Merged

Do not show 'pip3_import' as alternative to 'pip_install' in README#398
thundergolfer merged 1 commit intomasterfrom
jonathon--remove-pip3_import_refs-from-README

Conversation

@thundergolfer
Copy link
Copy Markdown

Partially addresses #397, specifically:

Then I read the instructions again, tried pip3_import, which doesn't exist (under pip.bzl). ...

pip3_import is legacy now and not provided in python/pip.bzl, so shouldn't be commented as an alternative to pip_install.

cc @dayfine


PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

Copy link
Copy Markdown
Contributor

@hrfuller hrfuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@thundergolfer thundergolfer merged commit 5e92eac into master Jan 5, 2021
@thundergolfer thundergolfer deleted the jonathon--remove-pip3_import_refs-from-README branch June 8, 2021 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants