Skip to content

Update pip_install dependencies#390

Merged
thundergolfer merged 5 commits intobazel-contrib:masterfrom
groodt:groodt-bump-pip-install-deps
Dec 24, 2020
Merged

Update pip_install dependencies#390
thundergolfer merged 5 commits intobazel-contrib:masterfrom
groodt:groodt-bump-pip-install-deps

Conversation

@groodt
Copy link
Copy Markdown
Collaborator

@groodt groodt commented Dec 12, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

  • Does not include precompiled binaries, eg. .par files. See CONTRIBUTING.md for info
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature (please, look at the "Scope of the project" section in the README.md file)
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Updates the versions of the PyPI dependencies that are used in the packaging rules.

pip: 19.3.1 -> 20.3.3 Changelog
pkginfo: 1.5.0.1 -> 1.6.1 Changelog
setuptools: 42.0.2 -> 44.1.0 Changelog
wheel: 0.33.6 -> 0.36.1 Changelog

Mostly adds Python 3.9 support, removes Python 3.4 support, adds macos Big Sur support and includes general bug fixes and improvements.

setuptools has been upgraded to the most recent version that supports Python 2.7. Newer versions remove support for Python 2.7 and ultimately start crashing on 2.7 from ~50.x.x. Until Bazel or the rules remove support for 2.7 it probably isn't appropriate to remove support for 2.7 in the packaging rules. If my assumption is incorrect, I can adjust to update setuptools to the latest version.

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@google-cla google-cla bot added the cla: yes label Dec 12, 2020
@groodt groodt changed the title Update dependencies. Update pip_install dependencies Dec 12, 2020
@thundergolfer thundergolfer self-requested a review December 17, 2020 07:33
@hrfuller
Copy link
Copy Markdown
Contributor

hrfuller commented Dec 23, 2020

@thundergolfer can we merge this now that the pkg_rules thing is fixed? I'd like to use pip 20.3.3 API

@thundergolfer thundergolfer merged commit a164327 into bazel-contrib:master Dec 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants