Skip to content

doc: Fix pip.default arguments in multi-platform example#3358

Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom
hartikainen:fix-multi-platform-example
Oct 15, 2025
Merged

doc: Fix pip.default arguments in multi-platform example#3358
rickeylev merged 2 commits intobazel-contrib:mainfrom
hartikainen:fix-multi-platform-example

Conversation

@hartikainen
Copy link
Copy Markdown
Contributor

@hartikainen hartikainen commented Oct 15, 2025 •
edited
Loading

I was playing around with the multi-platform PyPI example and noticed that the pip.default arguments were wrong.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

gemini-code-assist bot commented Oct 15, 2025

Summary of Changes

Hello @hartikainen, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves an issue in the rules_python documentation where the pip.default function arguments were incorrectly specified in the multi-platform PyPI example. The changes update the os and cpu parameters to their correct forms, os_name and arch_name, ensuring the provided code examples are accurate and functional for users following the guide.

Highlights

  • Documentation Fix: Corrected the argument names for pip.default calls within the multi-platform PyPI example in the documentation.
  • Argument Renaming: The os argument has been updated to os_name and the cpu argument to arch_name to reflect the correct parameter names for defining platforms.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes the argument names in the pip.default examples in the multi-platform documentation, changing os and cpu to os_name and arch_name respectively. However, the examples are syntactically incorrect as they are missing commas between arguments. I've added comments with suggestions to fix this and also to improve the consistency of argument ordering for better readability.

@rickeylev rickeylev changed the title fix,doc: Fix pip.default arguments in multi-platform example doc: Fix pip.default arguments in multi-platform example Oct 15, 2025
@rickeylev
Copy link
Copy Markdown
Collaborator

rickeylev commented Oct 15, 2025

Thanks for the doc fix!

@rickeylev rickeylev merged commit 46167f5 into bazel-contrib:main Oct 15, 2025
1 of 3 checks passed
@hartikainen hartikainen deleted the fix-multi-platform-example branch October 15, 2025 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickeylev rickeylev rickeylev approved these changes

@aignas aignas Awaiting requested review from aignas aignas is a code owner

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@hartikainen @rickeylev