internal: make release to chdir before looking for version markers#3342
Conversation
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical bug in the internal release tool where it failed to correctly determine the next release version due to an incorrect working directory context. The fix involves reordering a directory change operation to ensure the versioning logic executes from the correct workspace root. Additionally, comprehensive unit tests have been introduced to validate the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request correctly addresses a bug in the release tool where the working directory was changed too late, causing an incorrect version determination. Moving the os.chdir call to the beginning of the main function is the right solution, ensuring that all subsequent operations run from the correct workspace root. The addition of the DetermineNextVersionTest class with its comprehensive test cases is excellent; it thoroughly validates the versioning logic under various conditions and improves the overall robustness of the script. The changes are well-implemented and the new tests provide great coverage.
The release tool wasn't determining the next version correctly because it was
in the wrong directory when that logic ran. To fix, chdir before that logic kicks off.