fix(uv): make uv lock rule work with platform python runtime#3303
fix(uv): make uv lock rule work with platform python runtime#3303aignas merged 1 commit intobazel-contrib:mainfrom
Conversation
A platform runtime is when the interpreter is provided as an absolute path to Python instead of bundled in the runfiles. The uv lock rule almost worked, it just didn't handle the runtime files being empty in such a case.
Summary of ChangesHello @rickeylev, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a bug in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request provides a simple and effective fix for an issue where the uv lock rule would fail with a platform Python runtime. The change correctly handles cases where runtime.files is None by initializing python_files to an empty depset, preventing downstream errors. The fix is clean, and the corresponding update to the changelog is accurate. The changes look good.
A platform runtime is when the interpreter is provided as an absolute path to Python
instead of bundled in the runfiles. The uv lock rule almost worked, it just didn't
handle the runtime files being empty in such a case.
To fix, use an empty depset to satisfy the subsequent APIs that use it.