@gemini-code-assist /review

@gemini-code-assist Check for code that uses the _native_rules_allowlist attribute elsewhere in the repository.

Hello @rickeylev, I'm performing the requested code review now.

Regarding your request to "Check for code that uses the _native_rules_allowlist attribute elsewhere in the repository," I am unable to perform repository-wide searches. My review capabilities are limited to the changes presented within this pull request's diffs. I recommend using your SCM's search functionality or local tools to perform such a search.

Code Review

This pull request aims to remove the _native_rules_allowlist attribute, as it is considered a no-op and is related to a deprecated flag. The changes are well-aligned with the stated objective.

Summary of Changes:

• python/private/attributes.bzl: The _native_rules_allowlist attribute, its associated loading of py_internal, and the _create_native_rules_allowlist_attrs function have been completely removed. This is consistent with the attribute being a no-op.
• python/private/py_runtime_rule.bzl: The import and usage of NATIVE_RULES_ALLOWLIST_ATTRS have been removed, which is a necessary cleanup after its removal from attributes.bzl.

Review Criteria Assessment:

• Correctness: The removal of a no-op attribute and its related code seems correct, especially given the context of deprecating the associated flag. The changes are consistent across the affected files.
• Maintainability: Removing dead code and unnecessary imports improves the overall maintainability and reduces cognitive load for future developers.

No issues were found within the scope of the provided diffs that would prevent this change from being merged.

Great work on this cleanup!

Huh. Is this attribute entirely unused? I thought there was a helper function that checked it, but a quick search didn't turn it up.