docs: fix pr doc builds by removing external_version_warning plugin#3244
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Sep 7, 2025
Merged
docs: fix pr doc builds by removing external_version_warning plugin#3244rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
cbba66a to
80979bf
Compare
Collaborator
Author
|
Turns out the doc build errors in PRs were an actual bug, not a flake. Found and fixed. |
aignas
approved these changes
Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc builds for PR were failing because the readthedocs_ext.external_version_warning
plugin wasn't handling something correctly. Activating it manually was originally
done to get the warning banners to appear, but it looks like RTD now displays a
warning banner without this special plugin being needed.
Since it's now unnecessary, remove the code that can activate it.