Skip to content

docs(toolchains): set dev_dependency=True on repo rule invocation#3127

Merged
rickeylev merged 3 commits intobazel-contrib:mainfrom
honglooker:patch-1
Aug 11, 2025
Merged

docs(toolchains): set dev_dependency=True on repo rule invocation#3127
rickeylev merged 3 commits intobazel-contrib:mainfrom
honglooker:patch-1

Conversation

@honglooker
Copy link
Copy Markdown
Contributor

@honglooker honglooker commented Jul 30, 2025 •
edited by rickeylev
Loading

Move dev_dependency = True to the repo rule invocation. The use_repo_rule call
doesn't support that arg.

@honglooker
Update toolchains.md
e103110 
Remove `dev_dependency = True` for use_repo_rule invocations - invalid kwarg
aignas
aignas previously requested changes Aug 1, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not what the bazel docs say here

@honglooker
Copy link
Copy Markdown
Contributor Author

honglooker commented Aug 4, 2025

Hmm, not what I'm seeing in our CI: https://github.com/protocolbuffers/protobuf/actions/runs/16726777050/job/47344412543#step:6:592

cc @rickeylev

@aignas
Copy link
Copy Markdown
Collaborator

aignas commented Aug 5, 2025

@meteorcloudy, could you please clarify if this is a bug in bazel or bazel docs?

@meteorcloudy
Copy link
Copy Markdown
Contributor

meteorcloudy commented Aug 11, 2025 •
edited
Loading

The repo_rule_proxy belongs to the repo rule proxy not use_repo_rule directive. So the correct usage is

local_runtime_repo(
    name = "local_python3",
    interpreter_path = "python3",
    on_failure = "fail",
    dev_dependency = True,
)

I can see how the doc might be confusing, happy to help review a PR to help clarify this!

/cc @Wyverald

@rickeylev rickeylev changed the title docs: update toolchains.md docs(toolchains): set dev_dependency=True on repo rule invocation Aug 11, 2025
@rickeylev rickeylev dismissed aignas’s stale review August 11, 2025 16:05

problem addressed

@rickeylev rickeylev enabled auto-merge August 11, 2025 16:06
@rickeylev rickeylev added this pull request to the merge queue Aug 11, 2025
Merged via the queue into bazel-contrib:main with commit 6038ac4 Aug 11, 2025
3 checks passed
@rickeylev
Copy link
Copy Markdown
Collaborator

rickeylev commented Aug 11, 2025

Thanks for fixing the docs @honglooker!

@honglooker
Copy link
Copy Markdown
Contributor Author

honglooker commented Aug 11, 2025

np :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickeylev rickeylev rickeylev approved these changes

@aignas aignas aignas left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@honglooker @aignas @meteorcloudy @rickeylev