Skip to content

fix: Fix whl_library in bazel vendor mode#3096

Merged
aignas merged 4 commits intobazel-contrib:mainfrom
omar-droubi:python-home-fix
Aug 7, 2025
Merged

fix: Fix whl_library in bazel vendor mode#3096
aignas merged 4 commits intobazel-contrib:mainfrom
omar-droubi:python-home-fix

Conversation

@omar-droubi
Copy link
Copy Markdown
Contributor

@omar-droubi omar-droubi commented Jul 15, 2025

Resolves #3079

  • Added PYTHONHOME to whl_library execution environment. Without it, the python interpreter is getting confused where it's running from when bazel --vendor_dir is used
  • In _get_toolchain_unix_cflags, the real path for python is used instead of the symlink.

@omar-droubi
fix: Fix whl_library in bazel vendor mode
95ff01d 
- Added PYTHONHOME to whl_library execution enviornment. Without
it the python interpretter is getting confused where it's running
from when bazel --vendor_dir is used. PYTHONHOME will be aquired
by running python in isolated mode, and the sys.prefix queried.
- In _get_toolchain_unix_cflags, the real path for python is used
instead of the symlink.
@omar-droubi
Copy link
Copy Markdown
Contributor Author

omar-droubi commented Jul 16, 2025

Hi @aignas, with regards to the tests, the bug this PR resolves occurs when there is a "bazel clean --expunge" between the "bazel vendor" and the "bazel build" commands. Is it possible to update the "integration_test_bzlmod_ubuntu_vendor" with a "bazel clean" ? I am not sure how impactful that would be on the CI performance.

integration_test_bzlmod_ubuntu_vendor:
<<: *reusable_build_test_all
name: "examples/bzlmod: bazel vendor"
working_directory: examples/bzlmod
platform: ubuntu2204
shell_commands:
- "bazel clean --expunge"
- "bazel vendor --vendor_dir=./vendor //..."
- "bazel clean --expunge"
- "bazel build --vendor_dir=./vendor //..."
- "rm -rf ./vendor"

@aignas
Copy link
Copy Markdown
Collaborator

aignas commented Jul 24, 2025

I would like to avoid adding bazel clean in the CI, maybe we could just add a line that does bazel vendor if it is not present yet. If we have regressions in the future, we can look into bazel clean usage.

aignas
aignas approved these changes Aug 7, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@aignas aignas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@aignas aignas enabled auto-merge August 7, 2025 13:08
@aignas aignas added this pull request to the merge queue Aug 7, 2025
Merged via the queue into bazel-contrib:main with commit babfc2b Aug 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aignas aignas aignas approved these changes

@rickeylev rickeylev Awaiting requested review from rickeylev rickeylev is a code owner

@groodt groodt Awaiting requested review from groodt groodt is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

PIP Installation failure when using partially vendorred dependencies using bazel vendor

2 participants

@omar-droubi @aignas