feat: support arbitrary target_settings in our platforms 3/n#2990
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Jun 20, 2025
Merged
feat: support arbitrary target_settings in our platforms 3/n#2990rickeylev merged 2 commits intobazel-contrib:mainfrom
rickeylev merged 2 commits intobazel-contrib:mainfrom
Conversation
ad72cb5 to
df5865e
Compare
Collaborator
|
I gave this a skim, but started to lose track of the diff, so I'll hold off on reviewing in depth. Mostly LGTM, though. |
With this PR we can support arbitrary target settings instead of just plain `constraint_values`. We still have custom logic to ensure that all of the tests pass. However, the plan is to remove those tests once we have simplified the wheel selection mechanisms and the `pkg_aliases` macro. I.e. if we have at most 1 wheel per platform that the `pypi` bzlmod extension passes to the `pkg_aliases` macro, then we can just have a simple `selects.with_or` where we list out all of the target platform values. This PR may result in us creating more targets but that is the price that we have to pay if we want to do this incrementally. The last remaining thing for bazel-contrib#2548 is to make sure that we are not parsing the user-friendly strings to get the `os` and the `cpu`. Work towards bazel-contrib#2747 Work towards bazel-contrib#2548 Work towards bazel-contrib#260
df5865e to
19ecb6f
Compare
rickeylev
approved these changes
Jun 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this PR we can support arbitrary target settings instead of just
plain
constraint_values. We still have custom logic to ensure that allof the tests pass. However, the plan is to remove those tests once we
have simplified the wheel selection mechanisms and the
pkg_aliasesmacro. I.e. if we have at most 1 wheel per platform that the
pypibzlmod extension passes to the
pkg_aliasesmacro, then we can justhave a simple
selects.with_orwhere we list out all of the targetplatform values.
This PR may result in us creating more targets but that is the price
that we have to pay if we want to do this incrementally.
Work towards #2747
Work towards #2548
Work towards #260