refactor(gazelle) Types for exposed members of python.ParserOutput are now all public#2959
Conversation
dougthor42
left a comment
There was a problem hiding this comment.
allows other py extensions to leverage the Python resolver logic
Can you elaborate on what these extensions are or might be?
TBH I'm hesitant to make any more of the gazelle go code truly public. I already am not a fan of the existing public items haha.
I'm hesitant because we don't have many maintainers for the gazelle stuff, and adding more public things means that changes need to be more careful.
I'll defer to @aignas on this, but otherwise the code changes are mostly fine. It's a very mechanical change.
|
@dougthor42 There may be gazelle extensions that generate other macros that have python dependencies and requires resolving Python imports. |
python.ParserOutput are now all public
|
@aignas Yes good point, just update to make them all public. |
dougthor42
left a comment
There was a problem hiding this comment.
Merge conflict but otherwise LGTM.
Update Update Update cchangelog Update struct
Export the members of
python.ParserOutputstruct to make it publicly accessible. This allows otherpyextensions to leverage the Python resolver logic for resolving Python imports, instead of have to duplicate the resolving logic.