refactor: change site_packages_symlinks to venv_symlinks#2939
Merged
rickeylev merged 5 commits intobazel-contrib:mainfrom May 29, 2025
Merged
refactor: change site_packages_symlinks to venv_symlinks#2939rickeylev merged 5 commits intobazel-contrib:mainfrom
rickeylev merged 5 commits intobazel-contrib:mainfrom
Conversation
aignas
reviewed
May 29, 2025
Collaborator
aignas
left a comment
There was a problem hiding this comment.
LGTM other than the nit.
python/private/py_executable.bzl
Outdated
| Args: | ||
| ctx: current rule ctx | ||
| site_packages: runfiles-root-relative path to the site-packages directory | ||
| venv_dir_map: todo |
Collaborator
There was a problem hiding this comment.
nit: only this TODO needs to be replaced.
aignas
approved these changes
May 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This generalizes the ability to populate the venv directory by adding and additional field,
kind, which tells which directory of the venv to populate. A symbolic constant is usedto indicate which directory so that users don't have to re-derive the platform and version
specific paths that make up the venv directory names.
This follows the design described by #2156 (comment)
This also changes it to a depset of structs to make it more forward compatible. A provider
is used because they're slightly more memory efficient than regular structs.
Work towards #2156