tests: refactor py_reconfig rules so less boilerplate is needed to add attrs#2933
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom May 24, 2025
Merged
Conversation
…into tests.dry.reconfig
dougthor42
approved these changes
May 24, 2025
Collaborator
dougthor42
left a comment
There was a problem hiding this comment.
I can't say that I fully understand it, but I don't see any glaring issues. So LGTM.
| This facilitates verify running binaries with different outer environmental | ||
| settings and verifying their output without the overhead of a bazel-in-bazel | ||
| integration test. | ||
| This facilitates verify running binaries with different configuration settings |
Collaborator
There was a problem hiding this comment.
This verbiage is a little odd to me. Is verify a command / action? If so, maybe add quotes or a reference?
This facilitates "verify" (the action) running binaries with different configuration settings
Collaborator
Author
There was a problem hiding this comment.
Ah, that's a typo. It should say something more like
This facilitates running binaries ... and verifying their output ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some minor refactoring of the py_reconfig rule so that it's easier to add attributes
that affect transition state. After this, just two spots have to be modified to
add an attribute (map of attrs, map of attr to transition label).