feat: Support constraints in pip_compile#2916
Conversation
|
The docs say that the What is more, I think it is possible to do this today without this PR?
Am I missing something here? |
Fair point, we could support a list instead of a single file/label instead.
The data attribute gets popped from the kwargs here, and then the .update rule here rules_python/python/private/pypi/pip_compile.bzl Lines 160 to 165 in a746b8f $(location) in the args but the file isn't in it's data deps. So your suggestion doesn't work at the moment.
|
|
But then it gets reincluded back in via I think I am missing something crucial here. Just by reading the code, this looks like it should work. What is the minimum example that does not work? |
e10255e fails. 102a76a is the minimal change to get it working again. I'm fine with that patch instead if you don't want to support an explicit arg. |
|
No, I think the extra attribute for constraints makes sense. The only remaining thing here then is to make it a list. |
3ae67df to
3f4f142
Compare
Signed-off-by: Vihang Mehta <vihang@gimletlabs.ai>
3f4f142 to
1038104
Compare
This adds in support to pass in a constraints file to pip-compile.
This is extremly useful when you want to uprade an indirect/intermediate
dependency to pull in security fixes but don't want to add said dependency to
the requirements.in file.