feat: add an env variable to toggle pipstar#2855
Merged
Conversation
This is a flag to start leveraging of the new codepahs. Work towards #260
rickeylev
approved these changes
May 3, 2025
Collaborator
rickeylev
left a comment
There was a problem hiding this comment.
I pushed a fix to wheel_installer_test. CI is passing.
I'll approve so you can merge, but since this is draft, i'll let you trigger merging
Collaborator
Author
|
I expected this to need more work to pass tests, thanks, will merge now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a flag to start leveraging of the new code paths. The Starlark
implementation has been added in 1.4 and has been reverted in the latest
release candidates. The
envvariable will be a good way to roll it out moregradually and get more testing.
For now we are switching only the
whl_libraryinternals as therequirements.txtfiles fromuvmay use*inpython_full_versionandplatform_versionthat are not yet fully supported (#2826).Main goals for this is to start using Starlark implementation so that we don't
have any hidden variables. What is more, having this in Starlark is the most
maintainable long-term solution for supporting cross-platform builds.
Work towards #260