feat: allow specifying arbitrary constraints for local toolchains#2829
Merged
rickeylev merged 12 commits intobazel-contrib:mainfrom May 3, 2025
Merged
Conversation
aignas
approved these changes
May 2, 2025
Collaborator
aignas
left a comment
There was a problem hiding this comment.
LGTM, but please add CHANGELOG.md entry to point to the new docs.
…into feat.local.toolchains.target.settings
…b.com/rickeylev/rules_python into feat.local.toolchains.target.settings
Collaborator
Author
|
changelog updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the ability for local toolchains to have arbitrary constraints set on them.
This allows accomplishing two goals:
entirely override an existing config and having to comment/uncomment the
MODULE.bazel file sections.
the repository from being initialized during toolchain resolution, even if it will
never match because of (1).