chore: add check for version_next markers#2542
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Jan 3, 2025
Merged
Conversation
Collaborator
|
I think I have already used 1.1.0 in a few places, but I agree with using such an approach. |
aignas
approved these changes
Jan 3, 2025
Collaborator
aignas
left a comment
There was a problem hiding this comment.
I think we should also add a note about this convention somwhere in our guidelines.
Collaborator
|
Removed the auto-merge in case you would like to add the note in this PR. |
Collaborator
Author
Good idea. I've updated contributing.md with the guidance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In a couple recent PRs, I put "VERSION_NEXT_{feature,patch}" as place holders since I
wasn't sure what the next appropriate version would be for unreleased code. e.g.
specifying
1.0.1becomes invalid if a subsequent PR would make it1.1.0.To help remind us to populate these values before a release, have the release workflow
check for the marker strings.