Fix packaging rules documentation generation#251
Merged
brandjon merged 2 commits intobazel-contrib:masterfrom Nov 11, 2019
Merged
Fix packaging rules documentation generation#251brandjon merged 2 commits intobazel-contrib:masterfrom
brandjon merged 2 commits intobazel-contrib:masterfrom
Conversation
For some reason the rendered docs for the packaging rules' weren't up-to-date. There's still some rendering issues due to the docstrings for these rules using an outdated format.
Move argument docstrings to proper doc= arg on the attrs. Use markdown formatting where possible. Regenerate docs.
aiuto
approved these changes
Nov 8, 2019
aiuto
left a comment
There was a problem hiding this comment.
The text is fine. The escaping of x vs. x is difficult to follow, but that may just be deficiencies of markdown.
Contributor
Author
|
I originally tried replacing all the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix formatting of docstrings and regenerate the pages. Fixes #250.