fix: Strip trailing slash for repo url#2495
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Dec 11, 2024
Merged
Conversation
rickeylev
approved these changes
Dec 11, 2024
Collaborator
|
Thanks for the PR! CI failures look unrelated, so I've approved and queued it. We'll have the CI stuff fixed in the next day or so. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strip potential trailing slash when building url on the case of relative path without up-references. In particular, this fixes using
experimental_index_urlwith a AWS CodeArtifact python repository, which currently fails package downloads due to an incorrect URL (with double//) being produced by this code.