chore: replace rules_proto with com_google_protobuf#2487
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Dec 9, 2024
Merged
chore: replace rules_proto with com_google_protobuf#2487rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
aignas
approved these changes
Dec 9, 2024
aignas
reviewed
Dec 9, 2024
Collaborator
aignas
left a comment
There was a problem hiding this comment.
We don't need to modify our MODULE.bazel?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rules_proto is deprecated and recent versions simply forward onto com_google_protobuf.
Older versions (e.g. 6.x used by us today), however, use the rules_proto or native
(Bazel builtin) implementation. When those older versions are used with Bazel 9,
which has removed various proto things, errors occur.
To fix, switch to using com_google_protobuf directly. More recent versions of rules_proto
just forward onto com_google_protobuf anyways, so this just removes the extra dependency
and having to deal with WORKSPACE setup.
Work towards #2469