fix: make sphinxdocs support directory inputs#2375
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Nov 7, 2024
Merged
fix: make sphinxdocs support directory inputs#2375rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
ae8ac81 to
a0b1a40
Compare
aignas
approved these changes
Nov 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic to relocate files assumed that all the inputs were plain file artifacts. When
a directory artifact was used, then
ctx.actions.symlink()would fail because it requiresthe output artifact and input target artifact to be the same type of file (plain file or
directory).
To fix, use
File.is_directoryto detect if the input is a directory or file, then calldeclare_file()ordeclare_directory()as appropriate. The latersymlink()call isthen happy the two args match.
Fixes #2374