fix: breakages in unused codepaths after recent refactors#2353
Merged
fix: breakages in unused codepaths after recent refactors#2353
Conversation
* There is no such method `common_runfiles.add_runfiles` * The docs say that `BuiltinPyInfo` might be None, but that case is not handled here
rickeylev
approved these changes
Oct 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no such method
common_runfiles.add_runfiles; useadd_targets()instead. Thisonly occurs when there are extra deps, which currently only Google-patches trigger.
The docs say that
BuiltinPyInfomight be None, but that case is not handled here. Thisoccurs in newer Bazel versions where the builtin PyInfo has been removed.