test(bzlmod): refactor pip_parse to make it more testable#2314
Merged
aignas merged 48 commits intobazel-contrib:mainfrom Oct 21, 2024
Merged
test(bzlmod): refactor pip_parse to make it more testable#2314aignas merged 48 commits intobazel-contrib:mainfrom
aignas merged 48 commits intobazel-contrib:mainfrom
Conversation
_create_whl_libraries func
…sers pass whl_mods by any name
rickeylev
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new
parse_modulesfunction in thepypi/extension.bzlcode to mimic the structure of the
pythonextension and to make it easier towrite unit tests against the extension itself. I have also written a few unit
tests to verify the generic structure.
Work towards #2268.