chore: move files out of private/common#2285
Merged
rickeylev merged 4 commits intobazel-contrib:mainfrom Oct 15, 2024
Merged
Conversation
The "common" subdir is an artifact of the original file layout in Bazel, which was only necessary so that internal-loads within Bazel's builtins functioned correctly. It's not necessary in rules_python.
aignas
approved these changes
Oct 11, 2024
…o refactor.nothing.in.common
|
Will the rules source link be updated at https://bazel.build/reference/be/python#rules? It points to https://github.com/bazelbuild/rules_python/blob/main/python/private/common/py_binary_rule_bazel.bzl. |
Collaborator
Author
|
Thanks for pointing that out! I haven't look at the Bazel hosted docs for the py rules in a awhile and didn't know they were pointing there. I'll file an issue against Bazel. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "common" subdir was just carried over from the original file layout in Bazel. It's not
necessary in rules_python. Remove it to simplify, since various newly added code is
going directly into private, not into private/common.