fix(whl_library): avoid excessive report_progress() messages#2280
Merged
rickeylev merged 3 commits intobazel-contrib:mainfrom Oct 9, 2024
Merged
fix(whl_library): avoid excessive report_progress() messages#2280rickeylev merged 3 commits intobazel-contrib:mainfrom
rickeylev merged 3 commits intobazel-contrib:mainfrom
Conversation
should close bazel-contrib#2206 with current behavior, we see really long progress messages in the console like ``` Running whl_library.ResolveRequirement(foobar_pip_deps_regex, regex==2023.12.25 --hash=sha256:0694219a1d54336fd0445ea3\ 82d49d36882415c0134ee1e8332afd1529f0baa5 --hash=sha256:086dd15e9435b393ae06f96ab69ab2d333f5d65cbe65ca5a3ef0ec9564dfe770 --hash=sha256:094ba3\ 86bb5c01e54e14434d4caabf6583334090865b23ef58e0424a6286d3dc --hash=sha256:09da66917262d9481c719599116c7dc0c321ffcec4b1f510c4f8a066f8768105 --\ hash=sha256:0ecf44ddf9171cd7566ef1768047f6e66975788258b1c6c6ca78098b95cf9a3d --hash=sha256:0fda75704357805eb953a3ee15a2b240694a9a514548cd49b3c51\ 24b4e2ad01b --hash=sha256:11a963f8e25ab5c61348d090bf1b07f1953929c13bd2309a0662e9ff680763c9 --hash=sha256:150c39f5b964e4d7dba46a7962a088fbc91\ f06e606f023ce57bb347a3b2d4630 --hash=sha256:1b9d811f72210fa9306aeb88385b8f8bcef0dfbf3873410413c00aa94c56c2b6 --hash=sha256:1e0eabac536b4cc7f\ 57a5f3d095bfa557860ab912f25965e08fe1545e2ed8b4c --hash=sha256:22a86d9fff2009302c440b9d799ef2fe322416d2d58fc124b926aa89365ec482 --hash=sha256\ :22f3470f7524b6da61e2020672df2f3063676aff444db1daa283c2ea4ed259d6 --hash=sha256:263ef5cc10979837f243950637fffb06e8daed7f1ac1e39d5910fd29929e489a\ --hash=sha256:283fc8eed679758de38fe493b7d7d84a198b558942b03f017b1f94dda8efae80 --hash=sha256:29171aa128da69afdf4bde412d5bedc335f2ca8fcfe448\ ... ```
rickeylev
approved these changes
Oct 8, 2024
Collaborator
rickeylev
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the PR!
Contributor
Author
|
seems like the status check errors on the merge queue are transient errors? i'm not too familiar with the setup |
Collaborator
|
Yeah, looks like a network flake. Re-queued. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the current behavior, we see really long progress messages in the console like
This spams the console and isn't very useful.
To fix, only print up to the first white space, which captures the important information
(e.g. "regex==2024.12.25") and is brief.
Closes #2206