fix: pass kwargs env to both update and test targets#2277
fix: pass kwargs env to both update and test targets#2277aignas merged 2 commits intobazel-contrib:mainfrom
env to both update and test targets#2277Conversation
|
Seems reasonable to me. If it's not too much a hassle, it'd be good to write an automated test for this to avoid future breakage. |
aignas
left a comment
There was a problem hiding this comment.
Could you please add a CHANGELOG note to mentioned what was fixed?
Done! |
5d26d19 to
6c29c8a
Compare
|
|
||
| py_binary( | ||
| name = name + ".update", | ||
| env = env, |
There was a problem hiding this comment.
I'm surprised that we need the fake USERPROFILE only for _test and not for .update too.
Why is that the case?
There was a problem hiding this comment.
Well... X_test runs as a Bazel action. X.update is only expected to be invoked by the user directly, in a normal environment.
There was a problem hiding this comment.
Seems like a possible source of confusion to have different behavior here, but I trust your (and @aignas's) judgement on this.
6c29c8a to
f66e55a
Compare
Fixes #2270.