feat(toolchains): default py_runtime.implementation_name to cpython#2272
Merged
aignas merged 1 commit intobazel-contrib:mainfrom Oct 7, 2024
Merged
Conversation
aignas
approved these changes
Oct 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This defaults
py_runtime.implementation_nametocpython, the value that is most likelyto be used. This is done not only because it's the most likely value, but because of how
it affects whether precompiling works.
Within py_runtime, automatically computing
pyc_tagrequires bothimplementation_nameand Python version information. With upcoming changes to make
--python_versionalwaysset to the correct value, it'll make enabling precompiling easier, especially if there
are custom toolchains defined.