feat: add py_wheel.compress to control using compression#2260
Merged
rickeylev merged 3 commits intobazel-contrib:mainfrom Oct 1, 2024
Merged
Conversation
This is useful for development where, for large wheels, a significant portion of the time can be spent compression native binaries Fixes bazel-contrib#2240
Collaborator
|
I was going to ask for it to be an int attribute, but after zipping up some shared libraries to see how compression affects them, I'm not so sure:
So a bool seems about equivalent. I posted in our maintainer chat to see if anyone feels strongly about it being an int instead. They're probably into their weekend by now, though, so we'll give them until monday to respond. |
rickeylev
requested changes
Sep 27, 2024
Collaborator
rickeylev
left a comment
There was a problem hiding this comment.
Please update CHANGELOG.md to note the new feature.
Otherwise pretty much LGTM
Member
Author
|
pushed the changelog, any feedback from folks on the bool vs int? |
Collaborator
|
There was a mild preference for int, but not strong opinions. Worst case, we can add a compress_level arg. |
rickeylev
approved these changes
Oct 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is useful for development where, for large wheels, a significant
portion of the time can be spent compression native binaries
Fixes #2240