fix(sphinx): Support python 3.9 in Sphinx rules#2208
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Sep 9, 2024
Merged
fix(sphinx): Support python 3.9 in Sphinx rules#2208rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
rickeylev
approved these changes
Sep 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The implementation of the Sphinx related rules uses language features and types only available in python > 3.9. To the best of my understanding,
rules_pythonaims to support python3.9 and therefore this patch usestyping-extensionsinstead of the built-in types.After this change, one can use the
sphinx_build_binaryto create Sphinx docs using 3.9 runtime.This fixes #2207