feat(toolchain): add patch_strip attr for python_repository#2201
Merged
rickeylev merged 6 commits intobazel-contrib:mainfrom Sep 9, 2024
Merged
feat(toolchain): add patch_strip attr for python_repository#2201rickeylev merged 6 commits intobazel-contrib:mainfrom
rickeylev merged 6 commits intobazel-contrib:mainfrom
Conversation
rickeylev
approved these changes
Sep 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This value has been hardcoded for a long time, so let's add the
patch_stripattribute to the
WORKSPACEsetups now so that we add less tech debt in thebzlmodworld later and need to migratebzlmodusers from the hard codedvalue to something that can be configured.
This should be backwards compatible because of the default
intvalue of1for the
patch_stripattribute.Summary:
patch_striptopython_repository.TOOL_VERSIONS.Work towards #2081.