feat(rules): add build_data_file field to PyExecutableInfo#2181
Merged
feat(rules): add build_data_file field to PyExecutableInfo#2181
Conversation
PyExecutableInfo was added in #2166 with the field `runfiles_without_exe` that intentionally excludes unrelated files. But, within Google we found that we need to pick up the file with build stamp information at that stage as well, so it is being additionally exposed.
rickeylev
approved these changes
Sep 4, 2024
Collaborator
rickeylev
left a comment
There was a problem hiding this comment.
Mostly LGTM. Just the small defense-in-depth type of change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyExecutableInfo was added in #2166 with the field
runfiles_without_exethat intentionally excludes files that are specific tothat target/executable, such as the build data file (which may contain the target name,
or other target-specific information).
However, consuming tools (such as ones used within Google) may need to derive a file from
that build data, override it completely, or be happy with its content as is. To aid that
case, expose it via PyExecutableInfo.