fix(py_wheel): Avoid reliance on bash in py_wheel macro.#2171
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Aug 31, 2024
UebelAndre:wheel
Merged
fix(py_wheel): Avoid reliance on bash in py_wheel macro.#2171rickeylev merged 1 commit intobazel-contrib:mainfrom UebelAndre:wheel
py_wheel macro.#2171rickeylev merged 1 commit intobazel-contrib:mainfrom
UebelAndre:wheel
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to modernize an older repo I tried building wheels on windows and ran into a failure:
This appears to be caused by the
py_wheel_distrule which gets caught by//.... This target should be considered a side-effect/optional target ofpy_wheel. To fix:manual, so it's only built when explicitly requested.isn't required.