refactor: move bootstrap tests to their own directory#2168
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Aug 31, 2024
Merged
refactor: move bootstrap tests to their own directory#2168rickeylev merged 2 commits intobazel-contrib:mainfrom
rickeylev merged 2 commits intobazel-contrib:mainfrom
Conversation
Collaborator
Author
|
Well, that's a bit disappointing. I tried getting the commit history such that git recorded the BUILD.bazel change as a file move. And if you look at the individual commits, it is. But then the diff UI shows it as adding a new file without any relationship. Ah well. I wonder how it'll show up in the final commit history after squashing on submit. |
aignas
approved these changes
Aug 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the bootstrap tests to their own directory.
This is a bit for code cleanliness (it was a bit awkward having a bunch of non-analysis
tests in the middle of the analysis tests), but also to make importing the base_tests
directory into Google easier.