chore: add cxxopt std=c++14 to BCR presubmit config#2051
Merged
aignas merged 1 commit intobazel-contrib:mainfrom Jul 10, 2024
Merged
chore: add cxxopt std=c++14 to BCR presubmit config#2051aignas merged 1 commit intobazel-contrib:mainfrom
aignas merged 1 commit intobazel-contrib:mainfrom
Conversation
For some unknown reason, the BCR Mac jobs require `-std=c++14` when compiling. Without this, they fail with the error `C++ versions less than C++14 are not supported.` This only appears to happen in the BCR presubmits.
aignas
approved these changes
Jul 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some unknown reason, the BCR Mac jobs require
-std=c++14when compiling. Without this, they fail with the errorC++ versions less than C++14 are not supported.This only appears to happen in the BCR presubmits.