refactor: use http_archive for the stdlib list#2037
Merged
aignas merged 1 commit intobazel-contrib:mainfrom Jul 8, 2024
Merged
refactor: use http_archive for the stdlib list#2037aignas merged 1 commit intobazel-contrib:mainfrom
aignas merged 1 commit intobazel-contrib:mainfrom
Conversation
The `http_file` repo rules relied on Github-specific per-file HTTP API. Change this to use an `http_archive` repo rule, which refers to a simple URL containing the source tarball for stdlib-list.
aignas
approved these changes
Jul 8, 2024
Collaborator
aignas
left a comment
There was a problem hiding this comment.
LGTM, thanks a lot for the contribution!
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
http_filerepo rules relied on Github-specific per-file HTTP API. Change this to use anhttp_archiverepo rule, which refers to a simple URL containing the source tarball for stdlib-list.The release version of pypi/stdlib-list this is now pointing to is v0.10.0. This tag is slightly older than the original commit it was pointing to (
8cbc2067a4a0f9eee57fb541e4cd7727724b7db4) but, as discussed in pypi/stdlib-list#122, the only differences are build or doc related, there are no differences in the sources (see the diff).(Creating an associated issue didn't feel particularly useful but happy to do it if it's a mandatory part of the process!)