fix(gazelle): Consistent substitution pattern for python_default_visibility directive#1835
Merged
aignas merged 1 commit intobazel-contrib:mainfrom Apr 7, 2024
Merged
Conversation
…directive consistent with existing python_*_naming_convention
9f54a61 to
d9b4d54
Compare
Collaborator
Author
|
Notes:
|
aignas
approved these changes
Apr 7, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the substitution pattern for
python_default_visibilityconsistentwith the existing
python_*_naming_conventionpattern.In #1787 I added the
python_default_visibilitydirective and used asubstitution pattern
$python_root. However, I missed that the existingpython_*_naming_conventiondirectives include a trailing$.This PR is just: