fix: remove bzlmod pip.parse() annotations attribute#1808
Merged
aignas merged 4 commits intobazel-contrib:mainfrom May 19, 2024
Merged
fix: remove bzlmod pip.parse() annotations attribute#1808aignas merged 4 commits intobazel-contrib:mainfrom
aignas merged 4 commits intobazel-contrib:mainfrom
Conversation
Collaborator
|
LGTM, could you add a changelog entry to the Changed section please? |
Contributor
Author
|
@aignas updated, look ok? |
aignas
approved these changes
May 15, 2024
Collaborator
aignas
left a comment
There was a problem hiding this comment.
Thanks a bunch and thanks for being patient. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes unused attributes from the
bzlmodAPIs cleaning upthe docs and src code.