fix(internal): add WORKSPACE.bzlmod to ensure dependency separation#1806
Merged
rickeylev merged 4 commits intobazel-contrib:mainfrom Mar 21, 2024
Merged
fix(internal): add WORKSPACE.bzlmod to ensure dependency separation#1806rickeylev merged 4 commits intobazel-contrib:mainfrom
rickeylev merged 4 commits intobazel-contrib:mainfrom
Conversation
Before this PR, WORKSPACE file would be also used when using 'rules_python' under bzlmod and when developing locally it would yield to inconsistent behaviour between the examples and the main workspace. This PR ensures that the `dev_pip` is used via `bzlmod`. Whilst there may be a little bit of duplication from now on, it ensures that non-bzlmod code paths do not leak into the bzlmod dev setup.
e0c35b2 to
a6c7c82
Compare
675e859 to
effd851
Compare
rickeylev
approved these changes
Mar 21, 2024
Collaborator
|
Oh wow, how did we not notice this sooner? This would explain a few oddities we've seen. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR, WORKSPACE file would be also used when using
'rules_python' under bzlmod and when developing locally it would yield
to inconsistent behaviour between the examples and the main workspace.
This PR ensures that the
dev_pipis used viabzlmod. Whilst theremay be a little bit of duplication from now on, it ensures that
non-bzlmod code paths do not leak into the bzlmod dev setup.