Skip to content

build(internal_deps): Update 'maintained by' comments to be correct#1794

Merged
aignas merged 1 commit intobazel-contrib:mainfrom
dougthor42:update-maintained-by-comments
Mar 12, 2024
Merged

build(internal_deps): Update 'maintained by' comments to be correct#1794
aignas merged 1 commit intobazel-contrib:mainfrom
dougthor42:update-maintained-by-comments

Conversation

@dougthor42
Copy link
Copy Markdown
Collaborator

This fixes a minor error in the "maintained by" comments in
./MODULE.bazel and ./python/pip_install/repositories.bzl. The
comments now agree with what DEVELOPING.md says.

@dougthor42
Copy link
Copy Markdown
Collaborator Author

dougthor42 commented Mar 11, 2024

Note: I'm not sure if fix(internal_deps) is the best type and scope for the PR. The PR has no impact on end users but does have a very minor impact on developers. Oh I didn't see the build type. Updated to build(internal_deps).

I found this while working on #1578.

@dougthor42 dougthor42 marked this pull request as ready for review March 11, 2024 19:00
@dougthor42 dougthor42 requested a review from rickeylev as a code owner March 11, 2024 19:00
@dougthor42 dougthor42 changed the title fix(internal_deps): Update 'maintained by' comments to be correct build(internal_deps): Update 'maintained by' comments to be correct Mar 11, 2024
@aignas aignas enabled auto-merge March 12, 2024 00:07
@aignas
Copy link
Copy Markdown
Collaborator

aignas commented Mar 12, 2024

@coeuvre, do you know what the build failure is about? It seems to fail with the RBE setup, but this PR hasn't changed anything, nor have we changed rules_python config regarding RBE in recent days.

@aignas aignas added this pull request to the merge queue Mar 12, 2024
@coeuvre
Copy link
Copy Markdown

coeuvre commented Mar 12, 2024

@aignas Sorry, I recently made some changes to Bazel CI and accidentally broke RBE config for Bazel 6.4.0. It is fixed now.

Merged via the queue into bazel-contrib:main with commit fdf9410 Mar 12, 2024
@dougthor42 dougthor42 deleted the update-maintained-by-comments branch March 13, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants