fix(coverage) add coverage support for python 3.12#1727
Merged
aignas merged 19 commits intobazel-contrib:mainfrom Feb 6, 2024
Merged
fix(coverage) add coverage support for python 3.12#1727aignas merged 19 commits intobazel-contrib:mainfrom
aignas merged 19 commits intobazel-contrib:mainfrom
Conversation
* chore(coverage): bump coverage to 7.4.1 * style: update comments on how to update coverage * fix(coverage): add cp312 support
Contributor
Author
|
I've not figured out how to use my local instance of rules_python to verify the changes are working as expected. |
Collaborator
|
The bzlmod example is failing when it is just trying to run bazel coverage and it seems that tho patch that we apply to the wheel may need revising. I think just doing bazel fetch for all of the coverage deps whilst in the rules_python workspace should be enough to test this. Maybe adding a skylib build_test to do that in tests/coverage/BUILD.bazel or similar would be good. |
Contributor
Author
|
If I am working on cd /examples/bzlmod
bazel coverage //...
# 8 fail locally |
* examples/bzlmod - bazel coverage //tests:version_3_10_takes_3_9_subprocess_test was always failing due to .coveragerc generated file not being unique * generating the locv report resulted in messages going to stdout/stderr that resulted in test failures. To fix this, we run with --quiet. If VERBOSE_COVERAGE is defined we will output to stderr.
update the patch file for coverage/__main__
Contributor
Author
|
Note that #1734 should be merged before this PR. |
* `bazel coverage ...` in the same fashion as `bazel test ...`
…t-add-coverage-for-3.12
* update the python_bootstrap_template to default /dev/null for stdout/stderr
* reverted presubmit 6.4.0 bazel ubuntu test case * added changelog information * remove setting stdin to /dev/null
…t-add-coverage-for-3.12
Contributor
Author
|
@aignas this PR is ready for merge as well. Thank you! |
aignas
approved these changes
Feb 6, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: