fix(py_wheel): Fix parsing errors with requires_file attribute.#1719
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Jan 24, 2024
UebelAndre:requires
Merged
fix(py_wheel): Fix parsing errors with requires_file attribute.#1719rickeylev merged 1 commit intobazel-contrib:mainfrom UebelAndre:requires
requires_file attribute.#1719rickeylev merged 1 commit intobazel-contrib:mainfrom
UebelAndre:requires
Conversation
Contributor
Author
|
@aignas Do you think this needs a note in the CHANGELOG since the original feature has yet to be released? |
rickeylev
approved these changes
Jan 24, 2024
Collaborator
rickeylev
left a comment
There was a problem hiding this comment.
Nah, no changelog entry is needed for a fix to something unreleased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
requires_fileandextra_requires_filesattributes added by #1710 break wheels by leaving trailing;and currently do not supportrequirements.infiles with comments following a constraint on the same line. This PR fixes these issues.