fix: fix launching Python 3.11 from <3.8 on macOS#1709
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Jan 23, 2024
Merged
fix: fix launching Python 3.11 from <3.8 on macOS#1709rickeylev merged 2 commits intobazel-contrib:mainfrom
rickeylev merged 2 commits intobazel-contrib:mainfrom
Conversation
On macOS, some older versions of Python leak __PYVENV_LAUNCHER__ into the interpreter's environment variables. Starting with Python 3.11, this causes problems with Python being able to start correctly when launched from the Python bootstrap template. This change introduces a workaround to prevent the problematic environment variable from leaking into launched subprocesses. I've verified this problem exists with the version of Python 3.7 included with Xcode, and there are reports of it also being an issue with the Python 3.8 included with Xcode. Later versions of Python have fixed this. Context: - https://issues.pigweed.dev/310293060 - xonsh/xonsh#3576 (comment) - pypa/virtualenv#1458
rickeylev
approved these changes
Jan 23, 2024
Collaborator
rickeylev
left a comment
There was a problem hiding this comment.
per chat, I think this just needs to be updated to head, then CI will be happy. Otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, some older versions of Python leak PYVENV_LAUNCHER into
the interpreter's environment variables. Starting with Python 3.11, this
causes problems with Python being able to start correctly when launched
from the Python bootstrap template. This change introduces a workaround
to prevent the problematic environment variable from leaking into
launched subprocesses.
I've verified this problem exists with the version of Python 3.7
included with Xcode, and there are reports of it also being an issue
with the Python 3.8 included with Xcode. Later versions of Python have
fixed this.
Context: