chore: remove MODULE.bazel.lock and ignore it#1680
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Jan 13, 2024
Merged
chore: remove MODULE.bazel.lock and ignore it#1680rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
rickeylev
approved these changes
Jan 11, 2024
Collaborator
rickeylev
left a comment
There was a problem hiding this comment.
Can you update the change description to better explain why? Is it just to avoid the potential for the merge conflits? That's fine; I can get on board with that (such conflicts are really annoying), even though regenerating after a conflict should be pretty easy and cheap since our project is small.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When we use the latest
bazelrelease in therules_pythonmodule, then the lock file gets created, but I am not sure if
we should commit it in. Since the lock file is very useful
for local development as it speeds up dependency refetching,
this PR disables it as advised in the issue below. Whilst at
it, the
bzlmodexample also removes it for smaller diffswhen we develop extensions.
See bazelbuild/bazel#20369