chore: fix sphinx requirements#1648
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Dec 21, 2023
Merged
Conversation
Them getting out of sync was a problem in a few other PRs and at the moment they are identical, so maybe we can remove one and assume that they are the same on all platforms?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR the requirements files for
osxandlinuxwould besplit, but in practise they would be always the same. This means that
linuxusers would have to ask anosxuser to run a command wherewe could actually just reuse the same files.
Summary:
osxrequirementsosxrequirements and renamerequirements_linux.txtto just be
requirements.txtas both of the files are the same.