test(bzlmod): refactor tests to not depend on implementation details#1628
Merged
aignas merged 2 commits intobazel-contrib:mainfrom Dec 20, 2023
Merged
test(bzlmod): refactor tests to not depend on implementation details#1628aignas merged 2 commits intobazel-contrib:mainfrom
aignas merged 2 commits intobazel-contrib:mainfrom
Conversation
4 tasks
Collaborator
Author
|
The change can be smaller, so I'll revert the path usage within the tests and will keep the helper methods returnitg strings. The implementation of those should return Path.name as opposed to just Path. |
rickeylev
approved these changes
Dec 18, 2023
This refactors the `whl_mods` tests to not rely on the layout of the repositories, which I found to be needed whilst prototyping on bazel-contrib#1625. Whilst doing this I realized that in general it would be great to support `Path` instances in the `runfiles` library, but that should be done next time.
79f316a to
0435762
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactors the
whl_modstests to not rely on the layout of therepositories, which I found to be needed whilst prototyping on #1625.
Whilst doing this I realized that in general it would be great to
support
Pathinstances in therunfileslibrary, but that should bedone next time.