examples(pip_parse): fix circular deps with sphinx by breaking cycles#1596
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Dec 6, 2023
Merged
Conversation
When the pip_parse example was updated to use sphinx to demonstrate circular deps, its MODULE.bazel config was forgotten to also be updated to use the requirement_cycles feature to break the circular deps. Fixes bazel-contrib#1595
Solumin
approved these changes
Dec 6, 2023
Contributor
|
Oops. Thanks Ricky |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the pip_parse example was updated to use sphinx to demonstrate circular deps, its MODULE.bazel config was forgotten to also be updated to use the requirement_cycles feature to break the circular deps.
Fixes #1595