feat(twine): support 'bzlmod' users out of the box#1572
feat(twine): support 'bzlmod' users out of the box#1572rickeylev merged 13 commits intobazel-contrib:mainfrom
Conversation
|
If this is something we may want to do, I could add a test checking that we can:
|
9505116 to
86b630e
Compare
Yes, +1 on making it work out of the box. As a user, I don't really want to care about twine. I just want it to be easy to publish to pypi.
Is this something we could generalize? We have quite a few tests that rely on external packages having particular structures (e.g. circular deps, native deps, extra, etc). If we had a "local" pypi registry, we'd be able to more easily define and test the relevant scenarios. |
86b630e to
95ecae5
Compare
It depends on how we want the testing to be done. If we want manual tests, then starting a script to launch a server and then running a test script manually would be doable. If we want to integrate with the rest of the tooling so that it is automatic, it may be harder, but these are some ideas:
I am not sure I am going to pursue this academic exercise, so if anyone finds this message and is interested, feel free :) |
|
Not sure what to do with the failing Windows tests. Any ideas? |
Implements a test that starts a [
pypiserver] and checksthat the publishing with the new machinery still works.
Fixes #1369