feat(gazelle): use relative paths for resolved imports#1554
Merged
aignas merged 3 commits intobazel-contrib:mainfrom Nov 13, 2023
Merged
feat(gazelle): use relative paths for resolved imports#1554aignas merged 3 commits intobazel-contrib:mainfrom
aignas merged 3 commits intobazel-contrib:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
6399440 to
fbbc91b
Compare
aignas
reviewed
Nov 13, 2023
aignas
approved these changes
Nov 13, 2023
Contributor
Author
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Modify the Gazelle plugin so that when it adds a
depbecause of aresolvedirective it makes it a relative import if possible.The first commit adds a test for the existing behavior, where inside of
//package2the dependency//package2:resolved_packageis added. The second commit updates the test and the behavior so inside of//package2we add:resolved_packageinstead.