test(pystar): run pystar under Windows and Mac#1547
Merged
rickeylev merged 3 commits intobazel-contrib:mainfrom Nov 8, 2023
Merged
test(pystar): run pystar under Windows and Mac#1547rickeylev merged 3 commits intobazel-contrib:mainfrom
rickeylev merged 3 commits intobazel-contrib:mainfrom
Conversation
This is to have better test coverage. Only workspace for them is used because of limited CI slots. Also switches from last_green to last_rc, since a Bazel 7 RC is now available. This will help catch any changes that need to be backported from Bazel head to the Bazel 7 branch. Work towards bazel-contrib#1069
677de7a to
2398825
Compare
aignas
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to have better test coverage. Only workspace for them is used because of limited CI slots.
This also fixes the test_basic_windows test. The
--build_python_zipflag built into Bazel has a different default depending on the host OS (not target platform): true for windows, and false otherwise. Updated the test to force the flag value for reliable behavior between platforms.Work towards #1069