tests: disable bzlmod for workspace-only build_file_generation example#1539
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Nov 6, 2023
Merged
Conversation
The build_file_generation example only supports workspace style builds. The bzlmod equivalent is in `examples/bzlmod_build_file_generation` Work towards bazel-contrib#1520
aignas
approved these changes
Nov 6, 2023
Collaborator
aignas
left a comment
There was a problem hiding this comment.
I wonder if we should just merge the examples and add a warning to the Workspace file that someone is looking at the legacy example and that bzlmod is the preferred way. This obviously can be discussed separately
Collaborator
Author
|
Merging them is probably feasible, especially now that the bzlmod work has settled down. There are some features that are workspace only (e.g. entry points), that might make a simple consolidation harder, but we can probably figure something out there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The build_file_generation example only supports workspace style builds. The bzlmod equivalent is in
examples/bzlmod_build_file_generationWork towards #1520